Update the deployment templates to comply with the slack bot changes #766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest slack bot changes introduce two environment variables (bot token and app token). Take that changes into account for deployment manifests.
benjamin3322
commented
Aug 7, 2024
There was a problem hiding this comment.
Is this file generated somehow ?
|
@benjamin3322 this looks like a breaking change. Is it possible to keep implementation backwards compatible and add deprecation warnings to the old values? The slack go package might also need to be bumped. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest slack bot changes introduce two environment variables (bot token and app token). Take that changes into account for deployment
manifests.
I will also fix the documentation PR: keel-hq/keel.sh#53