Skip to content

Commit

Permalink
perf(client): reuse snpb.SubscribeResponse in RPC handler
Browse files Browse the repository at this point in the history
This pull request optimizes
`internal/storagenode/client.(*LogClient).Subscribe`. It reuses
`snpb.SubscribeResponse` to reduce heap allocations. Note that it does not reuse
the byte slice in the `snpb.SubscribeResponse`. It only reuses the struct
`snpb.SubscribeResponse` itself.
  • Loading branch information
ijsong committed Feb 28, 2024
1 parent d604b6f commit cd283ae
Show file tree
Hide file tree
Showing 2 changed files with 26 additions and 1 deletion.
4 changes: 3 additions & 1 deletion internal/storagenode/client/log_client.go
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,10 @@ func (c *LogClient) Subscribe(ctx context.Context, tpid types.TopicID, lsid type
defer func() {
close(out)
}()
var rsp snpb.SubscribeResponse
for {
rsp, rpcErr := stream.Recv()
rsp.Reset()
rpcErr := stream.RecvMsg(&rsp)
err := verrors.FromStatusError(rpcErr)
result := SubscribeResult{Error: err}
if err == nil {
Expand Down
23 changes: 23 additions & 0 deletions internal/storagenode/client/log_client_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,29 @@ func newMockStorageNodeServiceClient(ctrl *gomock.Controller, sn *storageNode, t
).DoAndReturn(func(_ context.Context, req *snpb.SubscribeRequest, opts ...grpc.CallOption) (snpb.LogIO_SubscribeClient, error) {
nextGLSN := req.GetGLSNBegin()
stream := mock.NewMockLogIO_SubscribeClient(ctrl)
stream.EXPECT().RecvMsg(gomock.Any()).DoAndReturn(
func(m any) error {
sn.mu.Lock()
defer sn.mu.Unlock()
var glsns []types.GLSN
for glsn := range sn.logEntries {
glsns = append(glsns, glsn)
}
sort.Sort(byGLSN(glsns))
for _, glsn := range glsns {
if glsn < nextGLSN {
continue
}
nextGLSN = glsn + 1
rsp := m.(*snpb.SubscribeResponse)
rsp.GLSN = glsn
rsp.LLSN = sn.glsnToLLSN[glsn]
rsp.Payload = sn.logEntries[glsn]
return nil
}
return io.EOF
},
).AnyTimes()
stream.EXPECT().Recv().DoAndReturn(
func() (*snpb.SubscribeResponse, error) {
sn.mu.Lock()
Expand Down

0 comments on commit cd283ae

Please sign in to comment.