perf(benchmark): use grpc.SharedBufferPool for grpc.DialOption

When a client library parses incoming gRPC messages, it allocates new buffers frequently. This can result in the creation of a large number of heap objects. However, gRPC offers an experimental feature called the shared buffer pool that can be used to address this issue. This pull request (PR) aims to optimize the gRPC receiving path using the shared buffer pool. Various experiments have shown that this optimization leads to a decrease in CPU time of runtime.gcBgMarkWorkers, depending on the workload. Since the shared buffer pool is experimental, it is applied only to the benchmark. Refs: - https://pkg.go.dev/google.golang.org/[email protected]/experimental#WithRecvBufferPool - https://pkg.go.dev/google.golang.org/[email protected]#SharedBufferPool
kakao · Feb 28, 2024 · d604b6f · d604b6f
1 parent 86a8155
commit d604b6f
Show file tree

Hide file tree

Showing 21 changed files with 96 additions and 1 deletion.
diff --git a/internal/admin/mrmanager/manager_mock.go b/internal/admin/mrmanager/manager_mock.go
diff --git a/internal/admin/replica_selector_mock.go b/internal/admin/replica_selector_mock.go
diff --git a/internal/admin/snmanager/manager_mock.go b/internal/admin/snmanager/manager_mock.go
diff --git a/internal/admin/snwatcher/snwatcher_mock.go b/internal/admin/snwatcher/snwatcher_mock.go
diff --git a/internal/admin/stats/repository_mock.go b/internal/admin/stats/repository_mock.go
diff --git a/internal/benchmark/loader.go b/internal/benchmark/loader.go
@@ -13,6 +13,8 @@ import (
 
 	"go.uber.org/multierr"
 	"golang.org/x/sync/errgroup"
+	"google.golang.org/grpc"
+	"google.golang.org/grpc/experimental"
 
 	"github.com/kakao/varlog/pkg/types"
 	"github.com/kakao/varlog/pkg/varlog"
@@ -54,7 +56,9 @@ func NewLoader(cfg loaderConfig) (loader *Loader, err error) {
 			if scli != nil {
 				return scli, nil
 			}
-			cli, err := varlog.Open(context.TODO(), loader.cid, loader.mraddrs)
+			cli, err := varlog.Open(context.TODO(), loader.cid, loader.mraddrs, varlog.WithGRPCDialOptions(
+				experimental.WithRecvBufferPool(grpc.NewSharedBufferPool()),
+			))
 			if err != nil {
 				return nil, err
 			}

diff --git a/internal/reportcommitter/client_mock.go b/internal/reportcommitter/client_mock.go
diff --git a/internal/storagenode/client/management_client_mock.go b/internal/storagenode/client/management_client_mock.go
diff --git a/pkg/mrc/metadata_repository_client_mock.go b/pkg/mrc/metadata_repository_client_mock.go
diff --git a/pkg/mrc/metadata_repository_management_client_mock.go b/pkg/mrc/metadata_repository_management_client_mock.go
diff --git a/pkg/varlog/admin_mock.go b/pkg/varlog/admin_mock.go
diff --git a/pkg/varlog/log_mock.go b/pkg/varlog/log_mock.go
diff --git a/pkg/varlog/log_stream_appender_mock.go b/pkg/varlog/log_stream_appender_mock.go
diff --git a/pkg/varlog/metadata_refresher_mock.go b/pkg/varlog/metadata_refresher_mock.go
diff --git a/pkg/varlog/options.go b/pkg/varlog/options.go
@@ -180,6 +180,14 @@ func WithGRPCInitialWindowSize(bytes int32) Option {
 	})
 }
 
+// WithGRPCDialOptions sets the grpc dial options.
+// See `google.golang.org/grpc.DialOption`.
+func WithGRPCDialOptions(grpcDialOptions ...grpc.DialOption) Option {
+	return newOption(func(opts *options) {
+		opts.grpcDialOptions = append(opts.grpcDialOptions, grpcDialOptions...)
+	})
+}
+
 const (
 	defaultRetryCount = 3
 )

diff --git a/pkg/varlog/replicas_retriever_mock.go b/pkg/varlog/replicas_retriever_mock.go
diff --git a/proto/admpb/admin_mock.go b/proto/admpb/admin_mock.go
diff --git a/proto/mrpb/mock/mrpb_mock.go b/proto/mrpb/mock/mrpb_mock.go
diff --git a/proto/snpb/mock/snpb_mock.go b/proto/snpb/mock/snpb_mock.go
diff --git a/vendor/google.golang.org/grpc/experimental/experimental.go b/vendor/google.golang.org/grpc/experimental/experimental.go
diff --git a/vendor/modules.txt b/vendor/modules.txt
@@ -557,6 +557,7 @@ google.golang.org/grpc/credentials/insecure
 google.golang.org/grpc/encoding
 google.golang.org/grpc/encoding/gzip
 google.golang.org/grpc/encoding/proto
+google.golang.org/grpc/experimental
 google.golang.org/grpc/grpclog
 google.golang.org/grpc/health
 google.golang.org/grpc/health/grpc_health_v1