Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport release-1.30] Correctly detect DNS address computation errors #5293

Open
wants to merge 1 commit into
base: release-1.30
Choose a base branch
from
Open

[Backport release-1.30] Correctly detect DNS address computation errors #5293

wants to merge 1 commit into from
+25 −4

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Nov 25, 2024

@twz123
Correctly detect DNS address computation errors
33d63d7 
The existing code is unable to compute meaningful DNS addresses if
the service CIDR doesn't describe a v4 network. Error out whenever the
network IP is not a v4 address until it is clear how to properly compute
the DNS address for a v6 network. Also, copy `address` by value so that
changes to it don't change `ipnet` as well.

Signed-off-by: Tom Wieczorek <[email protected]>
(cherry picked from commit 6824326)
(cherry picked from commit de30711)
@twz123 twz123 added bug Something isn't working area/configuration backport/release-1.29 PR that needs to be backported/cherrypicked to the release-1.29 branch labels Nov 25, 2024
@twz123 twz123 requested a review from a team as a code owner November 25, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kke kke Awaiting requested review from kke kke is a code owner automatically assigned from k0sproject/k0s-maintainers

@juanluisvaladas juanluisvaladas Awaiting requested review from juanluisvaladas juanluisvaladas is a code owner automatically assigned from k0sproject/k0s-maintainers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area/configuration backport/release-1.29 PR that needs to be backported/cherrypicked to the release-1.29 branch bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@twz123