Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport release-1.30] Correctly detect DNS address computation errors #5293

Open
wants to merge 1 commit into
base: release-1.30
Choose a base branch
from
Open

[Backport release-1.30] Correctly detect DNS address computation errors #5293

wants to merge 1 commit into from

Commits on Nov 25, 2024

  1. Correctly detect DNS address computation errors 

    The existing code is unable to compute meaningful DNS addresses if
the service CIDR doesn't describe a v4 network. Error out whenever the
network IP is not a v4 address until it is clear how to properly compute
the DNS address for a v6 network. Also, copy `address` by value so that
changes to it don't change `ipnet` as well.

Signed-off-by: Tom Wieczorek <[email protected]>
(cherry picked from commit 6824326)
(cherry picked from commit de30711)
    @twz123
    twz123 committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    33d63d7 View commit details
    Browse the repository at this point in the history