Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable ConstraintDual tests #19

Merged
merged 7 commits into from
Jan 3, 2024
+6 −5
Merged

Enable ConstraintDual tests #19

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
32b220f
Enable ConstraintDual tests
blegat Dec 21, 2023
30b84e3
Bump to MOI v1.24
blegat Jan 2, 2024
658b1cc
Fix
blegat Jan 2, 2024
b5ed21f
Update src/SDPLR.jl
blegat Jan 3, 2024
f90ba6f
Update src/SDPLR.jl
blegat Jan 3, 2024
5f1b2e1
Fix
blegat Jan 3, 2024
e9186b0
Fix
blegat Jan 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,6 @@ MathOptInterface = "b8f27783-ece8-5eb3-8dc8-9495eed66fee"
SDPLR_jll = "3a057b76-36a0-51f0-a66f-6d580b8e8efd"

[compat]
MathOptInterface = "1.22"
MathOptInterface = "1.24"
SDPLR_jll = "=100.2.300"
julia = "1.6"
5 changes: 4 additions & 1 deletion src/SDPLR.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@ module SDPLR

using SDPLR_jll
blegat marked this conversation as resolved.
Show resolved Hide resolved

const lib = SDPLR.SDPLR_jll.libsdplr
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const lib = SDPLR.SDPLR_jll.libsdplr
const libsdplr = SDPLR_jll.libsdplr

#const lib = "/home/blegat/git/sdplr/lib/libsdplr.so"
blegat marked this conversation as resolved.
Show resolved Hide resolved

include("bounds.jl")

function solve_sdpa_file(file)
Expand Down Expand Up @@ -142,7 +145,7 @@ function solve(
end
end
GC.@preserve blksz blktype b CAent CArow CAcol CAinfo_entptr CAinfo_type R lambda maxranks ranks pieces begin
ret = @ccall SDPLR.SDPLR_jll.libsdplr.sdplrlib(
ret = @ccall lib.sdplrlib(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ret = @ccall lib.sdplrlib(
ret = @ccall libsdplr.sdplrlib(

m::Csize_t,
numblk::Csize_t,
blksz::Ptr{Cptrdiff_t},
Expand Down
5 changes: 3 additions & 2 deletions test/MOI_wrapper.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ function test_runtests()
MOI.ConstraintName,
MOI.VariableName,
MOI.ObjectiveBound,
MOI.ConstraintDual, # TODO
MOI.SolverVersion,
],
optimal_status = MOI.LOCALLY_SOLVED,
Expand All @@ -45,8 +44,10 @@ function test_runtests()
r"test_model_ScalarFunctionConstantNotZero$",
r"test_model_delete$",
# Detecting infeasibility or unboundedness not supported
"INFEASIBLE",
"INFEAS",
"infeasible",
# Incorrect `ConstraintDual` for `vc2` for MacOS in CI
r"test_linear_integration",
# FIXME investigate
r"test_conic_SecondOrderCone_nonnegative_post_bound$",
r"test_conic_SecondOrderCone_negative_post_bound_2$",
Expand Down
Loading