-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable ConstraintDual tests #19
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
blegat
commented
Dec 21, 2023
•
edited
Loading
edited
- Needs [Utilities.CachingOptimizer] Enable fallback for ConstraintDual of variable indices MathOptInterface.jl#2373
- New release of MOI
This was referenced Dec 21, 2023
odow
reviewed
Jan 3, 2024
odow
reviewed
Jan 3, 2024
src/SDPLR.jl
Outdated
@@ -2,6 +2,9 @@ module SDPLR | |||
|
|||
using SDPLR_jll | |||
|
|||
const lib = SDPLR.SDPLR_jll.libsdplr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
const lib = SDPLR.SDPLR_jll.libsdplr | |
const libsdplr = SDPLR_jll.libsdplr |
odow
reviewed
Jan 3, 2024
odow
reviewed
Jan 3, 2024
src/SDPLR.jl
Outdated
@@ -142,7 +145,7 @@ function solve( | |||
end | |||
end | |||
GC.@preserve blksz blktype b CAent CArow CAcol CAinfo_entptr CAinfo_type R lambda maxranks ranks pieces begin | |||
ret = @ccall SDPLR.SDPLR_jll.libsdplr.sdplrlib( | |||
ret = @ccall lib.sdplrlib( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
ret = @ccall lib.sdplrlib( | |
ret = @ccall libsdplr.sdplrlib( |
Co-authored-by: Oscar Dowson <[email protected]>
Co-authored-by: Oscar Dowson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.