-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix fetch robot localization and navigation #1147
Conversation
2650f23
to
72a4dea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am sorry, but I am not sure if this PR works correctly.
(I do not know the effect of ukf_localization_node
.)
I think that this PR can be merged if jsk_patrol
demo works correctly everyday.
72a4dea
to
712cd64
Compare
I'm working in |
Going kitchen demo is now working stably. Robot head camera: https://drive.google.com/open?id=1K945-KXcfUQIeGudZpfd_9qWPyd95a8w |
@708yamaguchi
|
|
Thank you for robot demo and your explanation. |
e8656d8
to
411a5fe
Compare
failing due to missing packages https://travis-ci.org/jsk-ros-pkg/jsk_robot/jobs/602916381
|
@k-okada thank you! I updated. |
I add nodes which publish correct odom
/odom_corrected
and imu/imu_corrected
.Then I use these two corrected topics for
robot_localization
ukf
for localization.I wonder this change suppress odometry error.
/odom
does not haveframe_id
: /imu has an empty frame_id ZebraDevs/fetch_ros#70/odom
has zero covariance and overwrited in graft: https://github.com/fetchrobotics/fetch_robots/blob/indigo-devel/fetch_bringup/config/graft.yaml/imu
has zero covariance and overwrited in graft: https://github.com/fetchrobotics/fetch_robots/blob/indigo-devel/fetch_bringup/config/graft.yamlgraft
is no more maintenanced: Melodic Release Request ros-perception/graft#29 (comment) use robot_localization instead of graft ZebraDevs/fetch_robots#56correct_position.py
now testing on fetch15.
cc. @708yamaguchi @sktometometo
related: