Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use robot_localization instead of graft #56

Open
wants to merge 3 commits into
base: melodic-devel
Choose a base branch
from

Conversation

knorth55
Copy link
Contributor

@knorth55 knorth55 commented Oct 18, 2019

Switch from graft to robot_localization
graft is no more maintained.
(see ros-perception/graft#29)

we are now testing on our fetch robot with Indigo.
we cannot test it on melodic because we don't have melodic fetch and any plan to update our fetch to melodic.

related: jsk-ros-pkg/jsk_robot#1147

@knorth55
Copy link
Contributor Author

knorth55 commented Oct 18, 2019

in Indigo, there are several problems, for example

  • no header.frame_id in /imu
  • no angular_velocity.covariance in /imu
  • no twist.covariance in /odom

the 1st bug is probably fixed in Melodic.
the 2nd and 3rd bug does not matter in graft because graft override covariance.
But robot_localization does not seem to have this kind of override function.

k-okada added a commit to jsk-ros-pkg/jsk_robot that referenced this pull request Oct 27, 2019
fix fetch robot localization and navigation (graft vs robot_localization is still under discussion; ZebraDevs/fetch_robots#56 )
@moriarty
Copy link
Contributor

ping @erelson & @cjds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants