-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tally Face Changes #430
Merged
matheusmoreira
merged 9 commits into
joeycastillo:main
from
voloved:tally_counter_changes
Sep 17, 2024
Merged
Tally Face Changes #430
matheusmoreira
merged 9 commits into
joeycastillo:main
from
voloved:tally_counter_changes
Sep 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
voloved
force-pushed
the
tally_counter_changes
branch
from
September 3, 2024 21:17
491d5af
to
7e4612f
Compare
… fast scrolling, and toggling sound
voloved
force-pushed
the
tally_counter_changes
branch
from
September 8, 2024 15:40
ff4e523
to
a5a4dd1
Compare
…can happen immedietly
voloved
force-pushed
the
tally_counter_changes
branch
from
September 8, 2024 15:44
a5a4dd1
to
c02ec30
Compare
Use preprocessor macros to conditionally compile in Magic the Gathering initial value presets for the tally mark, thereby making them opt in.
Add common Yu-Gi-Oh card game life point preset values for the tally face, opt in by defining a preprocessor macro.
Don't reset the counters unless there are multiple presets. Move back to the first face directly if there are no presets to cycle through.
matheusmoreira
added
enhancement
New feature or request
watch-face
Related to a new or existing watch face
labels
Sep 8, 2024
Creates a macro that returns the size of the presets array, converting it into a compile time constant value that occupies no memory and that compilers can constant fold into other expressions potentially leading to dead code elimination.
matheusmoreira
added
the
next
This feature or pull request is present in the next branch
label
Sep 9, 2024
34 tasks
matheusmoreira
added
the
main
This feature or pull request is present in the main branch
label
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
main
This feature or pull request is present in the main branch
next
This feature or pull request is present in the next branch
watch-face
Related to a new or existing watch face
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
I play Magic: the Gathering, and being able to use my watch as the life-counter is really convenient. I have modified the default tally face so it can by used nicely as a life-counter.
Features Added
static const int16_t _tally_default
Controls
Alarm
Light
Mode
Video
One outdated item in the video is that toggling the sound no longer happens on the watch. It's now linked to the beep in preferences.
2024-08-06_07-07-22.mp4