Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tally Face Changes #430

Merged
merged 9 commits into from
Sep 17, 2024
Merged

Conversation

voloved
Copy link
Contributor

@voloved voloved commented Aug 6, 2024

Purpose

I play Magic: the Gathering, and being able to use my watch as the life-counter is really convenient. I have modified the default tally face so it can by used nicely as a life-counter.

Features Added

  • Multiple presets on the starting number that the face resets to.
    • Defaults are 0, 20, and 40, but can easily be changed by modifying static const int16_t _tally_default
  • Beeping of sound is now linked to the Beep setting in the global prefereneces.
  • Ability to display negative numbers.
    • This loses the ability to show numbers above 9,999, but a range of -99 to 9,999 should be good in almost all cases.
  • Fast scrolling by holding the increment or decrement button.

Controls

Alarm

  • Press: Decrement
  • Hold : Fast Decrement

Light

  • Press: Increment
  • Hold:
    • On initial value: Cycles through other initial values.
    • Else: Fast Increment

Mode

  • Press: Next face
  • Hold:
    • On initial value: Go to first face.
    • Else: Resets counter.

Video

One outdated item in the video is that toggling the sound no longer happens on the watch. It's now linked to the beep in preferences.

2024-08-06_07-07-22.mp4

voloved and others added 4 commits September 8, 2024 17:23
Use preprocessor macros to conditionally compile in Magic the Gathering
initial value presets for the tally mark, thereby making them opt in.
Add common Yu-Gi-Oh card game life point preset values
for the tally face, opt in by defining a preprocessor macro.
Don't reset the counters unless there are multiple presets.
Move back to the first face directly if there are no presets
to cycle through.
@matheusmoreira matheusmoreira self-assigned this Sep 8, 2024
@matheusmoreira matheusmoreira added enhancement New feature or request watch-face Related to a new or existing watch face labels Sep 8, 2024
matheusmoreira and others added 3 commits September 8, 2024 18:53
Creates a macro that returns the size of the presets array,
converting it into a compile time constant value that occupies
no memory and that compilers can constant fold into other expressions
potentially leading to dead code elimination.
@matheusmoreira matheusmoreira added the next This feature or pull request is present in the next branch label Sep 9, 2024
@matheusmoreira matheusmoreira merged commit 44b5434 into joeycastillo:main Sep 17, 2024
2 checks passed
@matheusmoreira matheusmoreira added the main This feature or pull request is present in the main branch label Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request main This feature or pull request is present in the main branch next This feature or pull request is present in the next branch watch-face Related to a new or existing watch face
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants