Merge next -- new watch faces before the freeze
#469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove test code
You can enter and monitor up to four different deadlines by providing their respective date and time. The watch face displays the remaining time at matching granularity, ranging from years to seconds.
Uses a simplistic set of jump tables to toggle daylight savings on and off.
…evolutionary_face)
This illuminates the LED only for the time that the button is pressed, and turns it off as soon as it's released, which is the behaviour of the original watch. I chose a led_duration of zero to represent "instant" and all bits set to represent "no LED", which is arbitrary but seemed more sensible to me.
This is a matter of personal preference, but "instant" is the behaviour of the original watch, and seems like the thing more people would expect. Feel free not to take this commit if you disagree, though.
Toggle between default behavior and leading zero with long-press of alarm button on page with 24h setting.
* origin/main: (119 commits) add an openocd.cfg for openocd 0.12.0 Fix compile errors and warnings in movement.c and shell.c faces/totp: avoid displaying when key is invalid faces/totp: fix error message not displayed bug faces/totp: remove dynamic memory allocation faces/totp: improve memory usage faces: restore simple_clock_face uf2conv: argument to `re.split` should be a rawstring movement: fix unintended timeout short circuiting movement: convert can_sleep an automatic variable faces/pulsometer: remember pulsometer measurement faces/pulsometer: remember pulsometer calibration faces/totp: update copyrights faces/totp: allow moving backwards through codes faces/clock: add 24h only feature faces/clock: update copyrights and credits faces/totp: delete leading underscores faces/totp: rename initializer macro to credential faces/totp: improve TOTP initializer labeling faces/totp: decode secrets when setting up ...
…ode. (#1) * Check that color is valid Instead of merely checking that COLOR is set, check that it is one of RED, BLUE or GREEN * Added ability to turn off sound and timer with modes * Added enum for mode --------- Co-authored-by: Wesley Ellis <[email protected]>
This makes it possible to do a bunch of things without having to keep touching the light button. I don't really see any downside with this. If you want the light to go off, just stop touching buttons.
…ling (#1) * Added subscreens to periodic table face; added title and faster scrolling * Resized buf for element display * Fixed scrolling to work on actual hardware * Added delay before _loop_text at title and bugfix on elements shorter than 6 char * Title screen displays when le_mode starts * Added documentation on usage and removed unneeded variable
* Holding light button on a non-element screen will turn on the light. * The alarm and led button press moves back to the currently-selected element symbol page rather than the next and previous one * Usage update
…it does cause an issue due to DST
Implements automatic DST data to the sunrise/sunset presets, making the whole system more automatic and therefore more reliable. Reviewed-by: Matheus Afonso Martins Moreira <[email protected]> GitHub-Pull-Request: #471
Adds the ability to tally negative counts, tally quickly by holding down the buttons as well as the ability to enable and cycle through multiple preset initial values for numerous contexts such as card games. Reviewed-by: Matheus Afonso Martins Moreira <[email protected]> GitHub-Pull-Request: #430
matheusmoreira
force-pushed
the
next
branch
from
7a1eb55
to
673f90b
Compare
PR #386 did not add the C file to the makefile, causing the build to fail at the link stage due to the missing object file and the symbols that were supposed to be provided by it. Adding the file to the build fixes #472. Reported-by: CarpeNoctem <[email protected]> Fixed-by: CarpeNoctem <[email protected]> Reviewed-by: Matheus Afonso Martins Moreira <[email protected]> GitHub-Issue: #472
This commit caused state restored from backup registers to be overwritten. It is thereby reverted until a better solution is found or movement is refactored. This reverts commit 524098b. Reviewed-by: Matheus Afonso Martins Moreira <[email protected]> References: #474
The new DST changes caused problems in one specific face - world_clock2. An incorrect variable was used due to a confusing name. It has been revised to fix the problems that were caused. Closes #475. Reported-by: CarpeNoctem <[email protected]> Fixed-by: David Volovskiy <[email protected]> Tested-by: CarpeNoctem <[email protected]> Tested-on-hardware-by: CarpeNoctem <[email protected]> GitHub-Pull-Request: #470 GitHub-Issue: #475
This reverts commit a715265, reversing changes made to 9c093f9. Insidious issues were found in the course of long term testing by the community, and further reviews of the code were not enough to pinpoint the issue and fix it. So for now the appropriate action is to revert these changes while development continues, and possibly merge them back in once they have been stabilized. Tested-on-hardware-by: David Volovskiy <[email protected]> Tested-on-hardware-by: CarpeNoctem <[email protected]> Tested-on-hardware-by: Krzysztof Gałka <@kshysztof@Discord>
The watch was not indicating to the user that it was in 24h mode when set to the leading zero 024h time format. This could lead to ambiguity and confusion, so make sure to indicate 24h mode. Closes #476. Reported-by: CarpeNoctem <[email protected]> GitHub-Issue: #476
This ensures that the display is always in a consistent state. Reported-by: CarpeNoctem <[email protected]> GitHub-Issue: #476
matheusmoreira
force-pushed
the
next
branch
3 times, most recently
from
58e2a08
to
ea5efb4
Compare
Closed
There was an issue where the simple clock's display would remain in 024h mode even after switching back to 12h/24h mode because it only took into account the leading zero bit, whose value is meaningless unless the 24h mode bit is also set. The issue is fixed by taking both bits into account. Closes #476. Reported-by: CarpeNoctem <[email protected]> GitHub-Issue: #476
There was an issue where the clock's display would remain in 024h mode even after switching back to 12h/24h mode because it only took into account the leading zero bit, whose value is meaningless unless the 24h mode bit is also set. The issue is fixed by taking both bits into account. Closes #476. Reported-by: CarpeNoctem <[email protected]> GitHub-Issue: #476
matheusmoreira
added
main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging in as many new features as possible before the feature freeze for the movement 2.0 refactor. Lots of new faces!
Included
Reverted
Testing
@CarpeNoctem
Tested
simple_clock_faceworld_clock_faceworld_clock2_facefrench_revolutionary_facealarm_facetimer_facestock_stopwatch_facetachymeter_facesunrise_sunset_facemoon_phase_faceminimal_clock_faceclose_enough_clock_facecountdown_facealarm_thermometer_facebeeps_facehigher_lower_game_facetally_facethermistor_readout_facevoltage_facepreferences_faceset_time_facefinetune_facenanosec_faceNot tested
@voloved
Tested