Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smallchess face #272

Merged
merged 13 commits into from
Sep 18, 2024
Merged

Smallchess face #272

merged 13 commits into from
Sep 18, 2024

Conversation

neutralinsomniac
Copy link
Contributor

This isn't the strongest chess engine in the world, but it's a pretty neat proof of concept.

WesleyAC
WesleyAC requested changes Dec 1, 2023
View reviewed changes
Copy link
Collaborator

@WesleyAC WesleyAC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fun :)

A couple minor things:

  • smallchesslib.h should probably live in movement/lib/smallchesslib/smallchesslib.h or something
  • There are some warnings generated in smallchesslib from functions that should be static, those should be made static

@neutralinsomniac neutralinsomniac force-pushed the smallchess branch 2 times, most recently from 9a4514d to 46aac0a Compare July 31, 2024 15:45
@neutralinsomniac
Copy link
Contributor Author

8 months later, I have implemented your changes :D

joeycastillo
joeycastillo approved these changes Sep 18, 2024
View reviewed changes
Copy link
Owner

@joeycastillo joeycastillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two months later, I can merge! This is so amazingly cool, just playing with it in the simulator; what a thing to be able to play chess with your wristwatch.

Thank you for your contribution!!

@joeycastillo joeycastillo merged commit e8f31be into joeycastillo:main Sep 18, 2024
2 checks passed
voloved pushed a commit to voloved/Sensor-Watch that referenced this pull request Sep 21, 2024
@neutralinsomniac @voloved
Smallchess face (joeycastillo#272)
b2794c3 
* smallchess face

* use correct game-state modifying board move function

* make show last work after undo

* use SCL_Game->ply instead of board[ply_byte]

* beep when cpu is done computing a move

* increase engine strength to ply 3

* match ply type and use the local variable where available

* fix warnings

* add doc to smallchess face

* smallchess: fix compile warnings

* smallchess: move smallchesslib.h to movement/lib
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WesleyAC WesleyAC WesleyAC requested changes

@joeycastillo joeycastillo joeycastillo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neutralinsomniac @joeycastillo @WesleyAC