Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How do you marginalize key frames discarded in LocalBAPRVIDP () #76

Open
NCHUPJ opened this issue May 7, 2020 · 2 comments
Open

How do you marginalize key frames discarded in LocalBAPRVIDP () #76

NCHUPJ opened this issue May 7, 2020 · 2 comments

Comments

@NCHUPJ
Copy link

NCHUPJ commented May 7, 2020

How do you marginalize key frames discarded in LocalBAPRVIDP ()

@ferreram
Copy link

ferreram commented May 7, 2020

This follows the VI-ORB-SLAM paper. Marginalization is only applied when optimizing the current frame (which is linked to the previous keyframe through the preintegrated IMU measurement and constrained by the current marginalization prior).
No information is really lost because a window of previous keyframes is included as fixed constraints in the optimization. However, compared to a sliding window / marginalization approach such as VINS-Mono, the uncertainty information on the fixed keyframes is lost which might lead to overconfidence during optimization but also ensure faster convergence and small drift.

@NCHUPJ
Copy link
Author

NCHUPJ commented May 7, 2020

@ferreram Thank you very much, look at the source code found marginalized only in TrackLocalMapWithIMU();
I can understand that the front has been marginalized, so the sliding window need not be marginalized, because the information of the frames in the sliding window is complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants