-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
quarto get_chapters()
compatibility
#129
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran get_chapters()
with index.html generated by the Quarto version of ottr, and got this error message:
Error in `dplyr::mutate()`:
ℹ In argument: `url = paste0(base_url, data_path)`.
Caused by error:
! object 'data_path' not found
The error stems from Line 472.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We pair programmed on this and determined it was a simple logic issue.
Can you test this again?
After applying my code suggestion, I get this data frame for
|
Co-authored-by: Howard Baek <[email protected]>
Thanks for these fixes @howardbaek I think this all makes sense. |
Purpose/implementation Section
What changes are being implemented in this Pull Request?
The
get_chapters()
function is used to collect chapter information. This is used in turn by thebookdown_to_leanpub()
function in ottrpal.It retrieves chapters based on the html node structure for bookdown but quarto has a different structure.
So this is adding compatibility for the quarto structure.
What this needs
The only true changes are in
R/bookdown_to_leanpub.R
the rest is styling changes.@howardbaek Can you double check this and see if it makes sense?