-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GHA file updates #20
Conversation
The broken url errors check is currently being re-run 🏃 |
The spelling errors check is currently being re-run 🏃 |
Re-rendered previews from the latest commit:
* note not all html features will be properly displayed in the "quick preview" but it will give you a rough idea. Updated at 2024-06-26 with changes from the latest commit 36d8526 |
This won't run properly the way you have it here because it is pulling files from main that don't yet have all the changes. Namely it doesn't have the config_automation.yml update for options yet. |
Scratch that. I'm wrong. I found the fix. Thanks for doing that. |
This looks in order to me. Ready to merge when you are @howardbaek But may need more testing? |
I just pushed a commit to address this issue. |
It seems like the GHAs that get triggered in this PR are all passing, but the render-all.yml isn't working: https://github.com/fhdsl/ottr/actions/runs/9102695262/job/25022955047#step:5:22 |
It can't find the docs/no_toc/ files. So I'll investigate where it is saving those files (if at all) |
After digging into this a bit more its failing because of differences of how the html files for quarto vs bookdown are structured. I'm working on adding functionality to ottrpal so this will work. |
jhudsl/ottrpal#129 needs to be reviewed before this PR can continue to be vetted. After it is reviewed and merged the ottrpal changes need to be:
|
Preparing for update to CRAN in jhudsl/ottrpal#132 |
@cansavvy This still isn't working: https://github.com/fhdsl/OTTR_Quarto/actions/runs/9507156191/job/26206018516 Maybe we are not pulling from the right docker image? |
Ah yes. It should be pulling from Good call. |
I got this error: https://github.com/fhdsl/OTTR_Quarto/actions/runs/9520628868/job/26246328655, so I added quarto to the Docker image in this PR: jhudsl/ottr-docker#20 |
Still not working. It seems like |
Okay I can dig into this tomorrow. |
From https://github.com/fhdsl/OTTR_Quarto/actions/runs/9617955283/job/26532508939 I could see that the ottr_quarto image wasn't being called and A separate docker image is being used here. That docker image could either be updated (probably a good plan or we just make this also use the docker image from the config file). I think its better that I update the ottrpal docker image and we keep as is. |
Pushed update to ottrpal docker image https://github.com/jhudsl/ottr_docker/actions/runs/9650571147/job/26616478289 |
Summary
This has to do with the first goal of streamlining the maintenance of OTTR github actions.
We want as few files to maintain as possible and as few copies of those files to update as possible.
So to that end I am updating these files here to see if they work with quarto OTTR version. These files were originally updated on this repo: jhudsl/OTTR_Template#746 But I'm testing them here.
In the future these files will be updated through OTTR sync and fhdsl/ottr has been added to the sync.yml file in that PR as well to make sure this happens.