Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DT and update tidyverse version #13

Merged
merged 10 commits into from
Mar 13, 2024
Merged

Add DT and update tidyverse version #13

merged 10 commits into from
Mar 13, 2024

Conversation

avahoffman
Copy link
Contributor

Hoping to get DT to work. As is, some of the dependencies are outdated for base_ottr:main.

@cansavvy
Copy link
Contributor

Hey @avahoffman Sorry I'm just now getting to this. Do we want this to be its own docker image to be managed, or should it just be the ottr_base is updated? Trying to figure out the use case for this as opposed to ottr_base.

@cansavvy
Copy link
Contributor

My suspicion is this is a change we need to happen to base_ottr so I made that change in the last commit, but if this is not what you intended, I'll revert that commit.

@avahoffman
Copy link
Contributor Author

Fine either way, but let me know once these updates are pushed so I can confirm it works for DaSL Collection, which requires DT.

@cansavvy cansavvy merged commit 93beab2 into main Mar 13, 2024
6 checks passed
@cansavvy cansavvy deleted the ottr-with-datatables branch March 13, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants