Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deleted setProxy logic from audit files and changed flow to use new function in cli-core #21

Merged
merged 10 commits into from
Feb 18, 2024
Merged

Deleted setProxy logic from audit files and changed flow to use new function in cli-core #21

merged 10 commits into from
Feb 18, 2024

Conversation

eranturgeman
Copy link
Contributor

@eranturgeman eranturgeman commented Feb 13, 2024 •
edited
Loading

  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....
  • All static analysis checks passed.
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.

Setting an Artifactory server as dependencies resolution registry logic got removed from 'audit' flow files and got moved to cli-core so we can use it in other flows as well.
Depends on: jfrog/jfrog-cli-core#1128

@eranturgeman eranturgeman added ignore for release Automatically generated release notes safe to test Approve running integration tests on a pull request labels Feb 13, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 13, 2024
@eranturgeman eranturgeman mentioned this pull request Feb 13, 2024
Merged
4 tasks
@eranturgeman
Merge branch 'dev' of https://github.com/jfrog/jfrog-cli-security int…
bd365ba 
…o resolution-from-artifactory-golang

# Conflicts:
#	go.mod
#	go.sum
@eranturgeman
.
c776e4d
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Feb 14, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 14, 2024
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Feb 14, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 14, 2024
@eranturgeman
Merge branch 'dev' of https://github.com/jfrog/jfrog-cli-security int…
e178d9a 
…o resolution-from-artifactory-golang

# Conflicts:
#	go.mod
#	go.sum
attiasas
attiasas approved these changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@attiasas attiasas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Don't forget to only merge when replacing with core Jfrog dev branch

@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Feb 18, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 18, 2024
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Feb 18, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 18, 2024
@eranturgeman
Merge branch 'dev' of https://github.com/jfrog/jfrog-cli-security int…
b3b1571 
…o resolution-from-artifactory-golang

# Conflicts:
#	go.mod
#	go.sum
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Feb 18, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 18, 2024
@github-actions GitHub Actions
Copy link

👍 Frogbot scanned this pull request and found that it did not add vulnerable dependencies.

@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Feb 18, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 18, 2024
@eranturgeman eranturgeman merged commit a98ce6c into jfrog:dev Feb 18, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@attiasas attiasas attiasas approved these changes

Assignees
No one assigned
Labels
ignore for release Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eranturgeman @attiasas