-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moved Golang remote registry setting logic from security-cli to cli-core #1128
Merged
eranturgeman
merged 7 commits into
jfrog:dev
from
eranturgeman:resolution-from-artifactory-golang
Feb 18, 2024
Merged
Moved Golang remote registry setting logic from security-cli to cli-core #1128
eranturgeman
merged 7 commits into
jfrog:dev
from
eranturgeman:resolution-from-artifactory-golang
Feb 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
attiasas
reviewed
Feb 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, try to rephrase the title
attiasas
added
improvement
Automatically generated release notes
and removed
ignore for release
Automatically generated release notes
labels
Feb 15, 2024
…solution-from-artifactory-golang
eranturgeman
had a problem deploying
to
frogbot
February 18, 2024 09:08 — with
GitHub Actions
Failure
eranturgeman
added
ignore for release
Automatically generated release notes
and removed
improvement
Automatically generated release notes
labels
Feb 18, 2024
…solution-from-artifactory-golang
eranturgeman
changed the title
Set Artifactory as dependencies resolution registry new function
Moved Golang remote registry setting logic from security-cli to cli-core
Feb 18, 2024
…solution-from-artifactory-golang
…golang' into resolution-from-artifactory-golang
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces an new function that enables setting an Artifactory server as dependencies resolution registry for Golang projects.
This logic previously existed in security-cli, and got removed from there in this PR: jfrog/jfrog-cli-security#21