build (info) updated on MP to v3 #28
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kochaika
reviewed
Dec 10, 2024
| @@ -16,4 +16,4 @@ content: | |||
| - introductionSection | |||
| - psiSection | |||
| environment_settings: | |||
| jvm_language_level: JDK_17 | |||
| jvm_language_level: JDK_19 | |||
There was a problem hiding this comment.
Looks like we can leave JDK_17:
#27 (comment)
UPD:
But if plugin changing it when uploads -- let's leave JDK_19
There was a problem hiding this comment.
I think it's a plugin bug
It seems the plugin doesn't take into account existing value and always rewrites this value according to your JDK
I intentionally changed it to 17 since plugin development requires 17 and there is no need to narrow down that range of "valid" JDK for this course
|
Also found a bug not directly connected to this PR. |
kochaika
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.