Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version update after uploading v19 to MP #240

Closed
wants to merge 2 commits into from
Closed

Conversation

kochaika
Copy link
Contributor

No description provided.

@kochaika kochaika requested a review from Geravant December 10, 2024 08:53
course-info.yaml Outdated
@@ -30,4 +30,4 @@ content:
tags:
- Beginner-friendly
environment_settings:
jvm_language_level: JDK_17
jvm_language_level: JDK_19
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need the JDK update here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we figured out here, no. Changed it back.

But the problem is wider: this change was made by the plugin before uploading course to MP. So, in the MP now JDK_19

@kochaika kochaika requested a review from Geravant December 18, 2024 16:01
@kochaika
Copy link
Contributor Author

This PR is no more actual. I made one more update and also fixed JDK version to 17 in MP too.
#242

@kochaika kochaika closed this Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants