-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: refactor packer templates #221
chore: refactor packer templates #221
Conversation
a003fa0
to
5a03c38
Compare
9df5318
to
d55d48d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! 🎉
sh './run-packer.sh build' | ||
),]) { | ||
// Required if packer needs to be installed | ||
sh 'command -v packer >/dev/null 2>&1 || bash ./install-packer.sh "${WORKSPACE}/.bin" "1.8.0"' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WDYT of a trackable version in an env var for packer here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I vote for, instead, installing packer in one of the images, as part of #198 (where it will be tracked instead)
Signed-off-by: Damien Duportal <[email protected]>
Signed-off-by: Damien Duportal <[email protected]>
…mit) Signed-off-by: Damien Duportal <[email protected]>
- Support multiple OS versions - Split HCL files to ease maintenance Signed-off-by: Damien Duportal <[email protected]>
…azon,azure and docker plugins to last versions Signed-off-by: Damien Duportal <[email protected]>
Co-authored-by: Hervé Le Meur <[email protected]>
58b6fde
to
e5e3d1c
Compare
=> Ready to review, and merge if approved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 🚢
* chore(packer) add support of packer 1.8.x Signed-off-by: Damien Duportal <[email protected]> * fix(packer) cleanup references to former .auto.pkrvars.hcl Signed-off-by: Damien Duportal <[email protected]> * feat(windows) increase the disk size above the 127 Gb limit (Azure limit) Signed-off-by: Damien Duportal <[email protected]> * chore: cleanup + refactor packer templates - Support multiple OS versions - Split HCL files to ease maintenance Signed-off-by: Damien Duportal <[email protected]> * chore(packer,updatecli) track plugin version with updatecli + bump amazon,azure and docker plugins to last versions Signed-off-by: Damien Duportal <[email protected]> * Apply suggestions from code review Co-authored-by: Hervé Le Meur <[email protected]> Co-authored-by: Hervé Le Meur <[email protected]>
* fix: correct cygwin path Added back grep sanity check Rel: jenkins-infra/helpdesk#2873 * chocoInstall + packer + list cygwin bin folder * replace ternary by if else * comment on cygwin tools listing * better function * function later... * comment out buggy function * remove packer * chore: refactor packer templates (#221) * chore(packer) add support of packer 1.8.x Signed-off-by: Damien Duportal <[email protected]> * fix(packer) cleanup references to former .auto.pkrvars.hcl Signed-off-by: Damien Duportal <[email protected]> * feat(windows) increase the disk size above the 127 Gb limit (Azure limit) Signed-off-by: Damien Duportal <[email protected]> * chore: cleanup + refactor packer templates - Support multiple OS versions - Split HCL files to ease maintenance Signed-off-by: Damien Duportal <[email protected]> * chore(packer,updatecli) track plugin version with updatecli + bump amazon,azure and docker plugins to last versions Signed-off-by: Damien Duportal <[email protected]> * Apply suggestions from code review Co-authored-by: Hervé Le Meur <[email protected]> Co-authored-by: Hervé Le Meur <[email protected]> * fix chocolatey updatecli manifest * replace echo by Write-Host * Update provisioning/windows-provision.ps1 Co-authored-by: Damien Duportal <[email protected]>
This change is a try to fix the packer template to anticipate for the upcoming new Windows server 2022 and Ubuntu 22.04 updates + fixes some non-functionnal items:
run-packer.sh
script in favor of "raw" packer commandsjenkins-agent.pkr.hcl
file into smaller files that can be reused project-wide (following usual hashicorp HCL project conventions:variables
file,locals
file, etc.)scripts/
toprovisioning/
to help newcomers mapping the concepts to Packer's documentationIt also bumps the packer plugins and start keeping track of them using updatecli: I hope that it would fix the recent azure plugin crash