fix: correct cygwin path #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added back grep sanity check Rel: jenkins-infra/helpdesk#2873
* chore(packer) add support of packer 1.8.x Signed-off-by: Damien Duportal <[email protected]> * fix(packer) cleanup references to former .auto.pkrvars.hcl Signed-off-by: Damien Duportal <[email protected]> * feat(windows) increase the disk size above the 127 Gb limit (Azure limit) Signed-off-by: Damien Duportal <[email protected]> * chore: cleanup + refactor packer templates - Support multiple OS versions - Split HCL files to ease maintenance Signed-off-by: Damien Duportal <[email protected]> * chore(packer,updatecli) track plugin version with updatecli + bump amazon,azure and docker plugins to last versions Signed-off-by: Damien Duportal <[email protected]> * Apply suggestions from code review Co-authored-by: Hervé Le Meur <[email protected]> Co-authored-by: Hervé Le Meur <[email protected]>
lemeurherve
commented
May 14, 2022
provisioning/windows-provision.ps1
Outdated
Comment on lines
68
to
78
| # function Choco-Install { | ||
| # [CmdletBinding()] | ||
| # param( | ||
| # [Parameter(Mandatory, ValueFromPipeline)] | ||
| # [string]$PackageName | ||
| # ) | ||
| # Process { | ||
| # Invoke-Command & "choco.exe" install $PackageName --yes --no-progress --limit-output --fail-on-error-output | ||
| # } | ||
| # } | ||
|
|
There was a problem hiding this comment.
Suggested change
| # function Choco-Install { | |
| # [CmdletBinding()] | |
| # param( | |
| # [Parameter(Mandatory, ValueFromPipeline)] | |
| # [string]$PackageName | |
| # ) | |
| # Process { | |
| # Invoke-Command & "choco.exe" install $PackageName --yes --no-progress --limit-output --fail-on-error-output | |
| # } | |
| # } | |
There was a problem hiding this comment.
I intent to add later a proper Choco-Install function, which would also look for potential CHOCOLATEY_$PackageNam.toUpper()_VERSION env var to pass as arg if exist
make worked great, but adding it to cygwin didn't, and since I have build already a lot of images on this PR, I postponed it.
|
from infra.ci:
😥 |
|
Adding the new VM image definition in Azure: |
LGTM! I'm currently adding them into Azure to improve tracking, I'll add you as reviewer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced "grep" sanity check by a listing of Cygwin tools folder (grep doesn't seems in the $PATH at that point)
Rel: jenkins-infra/helpdesk#2873