feat(rsyncd) allow overriding PV(C)s based on global value from parent chart #830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t chart Signed-off-by: Damien Duportal <[email protected]>
dduportal
force-pushed
the
feat/rsyncd/allow-using-parent-ingress-and-pvc
branch
from
414c0f1 to
40d4598
Compare
lemeurherve
previously approved these changes
Oct 5, 2023
Co-authored-by: Hervé Le Meur <[email protected]>
Signed-off-by: Damien Duportal <[email protected]>
lemeurherve
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to jenkins-infra/helpdesk#2649
Same idea as #817 and #818 , this PR allows passing template in rsync component definitions, for dynamic evaluation of the PVC name.