Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Hervé Le Meur <[email protected]>
  • Loading branch information
dduportal and lemeurherve authored Oct 5, 2023
1 parent 40d4598 commit f91f81f
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
1 change: 0 additions & 1 deletion charts/rsyncd/templates/_helpers.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ app.kubernetes.io/version: {{ .Chart.AppVersion | quote }}
app.kubernetes.io/managed-by: {{ .Release.Service }}
{{- end -}}


{{/*
Data directory volume definition. Might be defined from parent chart templates or autonomously
based on the presence of the global value provided by the parent chart.
Expand Down
4 changes: 2 additions & 2 deletions charts/rsyncd/tests/parent_values_test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ tests:
path: spec.template.spec.containers[0].volumeMounts[3].subPath
value: run
# Custom Rsyncd components
## jenkins (1 configmap volume mount + 1 data volume and 1 volumemount for data dir)
## jenkins (1 configmap volume mount + 1 data volume and 1 volume mount for data directory)
- equal:
path: spec.template.spec.volumes[2].name
value: datadir-jenkins
Expand Down Expand Up @@ -96,7 +96,7 @@ tests:
- equal:
path: spec.template.spec.containers[0].volumeMounts[5].readOnly
value: true
## hudson (1 configmap volume mount + 1 data volume and 1 volumemount for data dir)
## hudson (1 configmap volume mount + 1 data volume and 1 volume mount for data directory)
- equal:
path: spec.template.spec.volumes[3].name
value: datadir-hudson
Expand Down

0 comments on commit f91f81f

Please sign in to comment.