feat(mirrorbits-lite) allow defining ingress and PV(C)s from parent chart #817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…obal value from parent chart chore(mirrorbits-lite) increase unit test coverage to PV and PVC with their volumeMounts Signed-off-by: Damien Duportal <[email protected]>
Signed-off-by: Damien Duportal <[email protected]>
lemeurherve
reviewed
Oct 2, 2023
lemeurherve
reviewed
Oct 2, 2023
lemeurherve
approved these changes
Oct 2, 2023
dduportal
deleted the
feat/mirrorbits-lite/allow-using-parent-ingress-and-pvc
branch
This was referenced Oct 3, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to jenkins-infra/helpdesk#2649
This PR is an extract of #813 scoped to only
mirrorbits-liteIt introduces the following changes:
binaryvolume name todata(kept the same mountpoint)globalvalueglobal.ingress.enableddatavolume through a parent chart with aglobalvalueglobal.storage.enabled"mirrorbits-parent.pvc-name"template function to retrieve the claimName