Tvdb v4 migration #93
Conversation
|
Should be working without any bugs now. |
|
Should I include the TVSharper DLL inside the PR? Or is it better if you build the DLL from my TvDbSharper fork? |
I don't think so- I would say this PR is blocked until upstream merges your changes (HristoKolev/TvDbSharper#39) Alternatively we can migrate to the sdk I have generating (https://github.com/crobibero/tvdb-sdk-csharp) |
|
Hmm, I doubt he will merge my changes anytime soon since the last commit for that project is in 2022. Maybe we can keep this as an unoffical tvdb plugin until the changes are merged or we migrate to the sdk? |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if (dvdInfo is null) | ||
| { | ||
| item.IndexNumber = episode.Number; | ||
| } | ||
| else | ||
| { | ||
| item.IndexNumber = Convert.ToInt32(dvdInfo.Number, CultureInfo.InvariantCulture); | ||
| } |
Check notice
Code scanning / CodeQL
Missed ternary opportunity Note
| if (string.IsNullOrWhiteSpace(parts[1])) | ||
| { | ||
| threeletterNames = new[] { parts[0] }; | ||
| } | ||
| else | ||
| { | ||
| threeletterNames = new[] { parts[0], parts[1] }; | ||
| } |
Check notice
Code scanning / CodeQL
Missed ternary opportunity Note
|
Hi @scampower3 any updates on this? wondering if this is still being worked on, or is it going to be fixed by another PR |
Hey, this is PR isnt abandoned. This migration is more or less done last I checked. However, it is dependent on the changes made here. This PR is probably blocked till the schema on TVDB api site is fixed. |
|
Thank you very much for going through this adventure! |
Tvdb v4 migation in progress. Will set on draft till its done.
Some code commented out needs some clarification.
Fixes #47
Fixes #100
Using this fork of TVdbSharper: https://github.com/scampower3/TvDbSharperSwitched to: https://github.com/crobibero/tvdb-sdk-csharp