Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for tvdb v4 migration #110

Merged
merged 4 commits into from
Feb 19, 2024
Merged

Fixes for tvdb v4 migration #110

merged 4 commits into from
Feb 19, 2024

Conversation

BobSilent
Copy link
Contributor

This PR adds some fixes for #93 in TvdbMissingEpisodeProvider

  • Comparing Episodes compares SeasonNumber with Episode Number episode.ParentIndexNumber == otherEpisodeRecord.Number instead of episode.ParentIndexNumber == otherEpisodeRecord.SeasonNumber
  • Translation does not handle the case where two three letter codes are available
  • filtering for episodes of a season was removed with api change

@BobSilent BobSilent mentioned this pull request Feb 19, 2024
Merged
@Shadowghost Shadowghost merged commit 0fae371 into jellyfin:master Feb 19, 2024
4 checks passed
@jellyfin-bot jellyfin-bot mentioned this pull request Feb 11, 2024
Merged
@crobibero crobibero added the bug This PR or Issue describes or fixes something that isn't working label Feb 19, 2024
@BobSilent BobSilent deleted the fix-tvdb-v4-migration branch February 19, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shadowghost Shadowghost Shadowghost approved these changes

Assignees
No one assigned
Labels
bug This PR or Issue describes or fixes something that isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BobSilent @Shadowghost @crobibero