Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase resolution of train_test_split #611

Merged
merged 8 commits into from
Nov 20, 2024
Merged

Increase resolution of train_test_split #611

merged 8 commits into from
Nov 20, 2024

Conversation

0x2b3bfa0
Copy link
Member

@0x2b3bfa0 0x2b3bfa0 self-assigned this Nov 19, 2024
Copy link

cloudflare-workers-and-pages bot commented Nov 19, 2024

Deploying datachain-documentation with  Cloudflare Pages  Cloudflare Pages

Latest commit: b5d97ef
Status: ✅  Deploy successful!
Preview URL: https://5c48be84.datachain-documentation.pages.dev
Branch Preview URL: https://0x2b3bfa0-patch-1.datachain-documentation.pages.dev

View logs

Copy link
Contributor

@dreadatour dreadatour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you for the fix.
Need to deal with tests now and to be careful with different DB implementations as you've mentioned.

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.04%. Comparing base (21857af) to head (b5d97ef).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #611   +/-   ##
=======================================
  Coverage   88.04%   88.04%           
=======================================
  Files         102      102           
  Lines       10085    10086    +1     
  Branches     1373     1373           
=======================================
+ Hits         8879     8880    +1     
  Misses        865      865           
  Partials      341      341           
Flag Coverage Δ
datachain 87.98% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@0x2b3bfa0 0x2b3bfa0 merged commit 894c13d into main Nov 20, 2024
38 checks passed
@0x2b3bfa0 0x2b3bfa0 deleted the 0x2b3bfa0-patch-1 branch November 20, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants