Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inaccurate comment in split.py #612

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

0x2b3bfa0
Copy link
Member

@0x2b3bfa0 0x2b3bfa0 commented Nov 20, 2024

Continuation of #611, see #611 (comment).

To do:

  • Call abs always before comparison, and make sure we're always comparing positive numbers.
  • Check that we're using the right data types everywhere [un]signed integers? 64 bits? SQLite doesn't support uint64, but only int64.

@0x2b3bfa0 0x2b3bfa0 marked this pull request as draft November 20, 2024 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant