Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update gemfile #413

Open
wants to merge 1 commit into
base: staging
Choose a base branch
from
Open

chore: update gemfile #413

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ GEM
jekyll-seo-tag (~> 2.1)
minitest (5.22.3)
mutex_m (0.2.0)
nokogiri (1.15.6)
nokogiri (1.16.5)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this a dep of a dep? from PR description it seems this is. a dep of github pages. have we tested if the current github pages version works with this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i have absolutely no clue. it shouldn't be as it's specified at the top level but the vulnerability was from this.

also, no. this is because i have no idea where github pages are used + the gem is removed in next_gen ._. i'll test this out remotely

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi @harishv7 - checked with @alexanderleegs and we're not quite sure what github pages is actually being used for.

this gemfile is only being used for a few sites (self-hosted) and on further thinking i don't believe we use this gem at all.

i'm open to just marking the deps as not vuln on snyk - wdyt

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to github pages gem tbh, but I am okay to mark this to be ignored on snyk

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same, i'm just keeping it because i'm scared that uninstalling has unintended consequences, however improbable

i'll mark it on snyuk then

mini_portile2 (~> 2.8.2)
racc (~> 1.4)
octokit (4.25.1)
Expand Down