Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix(repair-form): set remote url correctly #1048

Merged

Conversation

kishore03109
Copy link
Contributor

@kishore03109 kishore03109 commented Dec 4, 2023

Problem

The remore was not set properly. Reason why this error was not caught eariler was beacuse git itself is tolerant to this error, but our BE logic is not as we check a strict string check.
Closes [insert issue #]

Solution

add .git at the end

Copy link
Contributor

@seaerchin seaerchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - technically this should work (and i checked against the git ui), but just to be safe:

  1. how does this error manifest?
  2. how did we fix the error? (assumption is just go on efs and fix error manually?)

@kishore03109
Copy link
Contributor Author

kishore03109 commented Dec 5, 2023

@seaerchin yes gh handles this gracefully. In our rollback handlers however, we do a strict string check in the function call isRemoteOriginCorrect, which was how i discovered that error

fix is simple, we can just re-run the repair form later after release for all ggs that exist in efs (need to be done after hours)

@seaerchin
Copy link
Contributor

eh dk why i didn't approve cos i clicked approve sia cb

@kishore03109 kishore03109 merged commit 3217eed into develop Dec 5, 2023
16 checks passed
This was referenced Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants