test(gitCommitService): add test cases #1047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 3, 2023
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
kishore03109
force-pushed
the
12-04-feat_gitFileSystem_safer_api
branch
from
5757b98 to
2a826b8
Compare
kishore03109
force-pushed
the
12-04-test_gitCommitService_add_test_cases
branch
from
d050e8c to
3d72484
Compare
kishore03109
force-pushed
the
12-04-feat_gitFileSystem_safer_api
branch
from
2a826b8 to
3050748
Compare
kishore03109
force-pushed
the
12-04-test_gitCommitService_add_test_cases
branch
from
3d72484 to
1bce332
Compare
kishore03109
force-pushed
the
12-04-feat_gitFileSystem_safer_api
branch
from
3050748 to
f812fd7
Compare
kishore03109
force-pushed
the
12-04-test_gitCommitService_add_test_cases
branch
from
1bce332 to
6f5c0d1
Compare
kishore03109
force-pushed
the
12-04-feat_gitFileSystem_safer_api
branch
from
f812fd7 to
ecc5966
Compare
kishore03109
force-pushed
the
12-04-test_gitCommitService_add_test_cases
branch
from
6f5c0d1 to
0b1d0b9
Compare
kishore03109
force-pushed
the
12-04-feat_gitFileSystem_safer_api
branch
from
ecc5966 to
c2f88d4
Compare
kishore03109
force-pushed
the
12-04-test_gitCommitService_add_test_cases
branch
from
0b1d0b9 to
79ec119
Compare
harishv7
reviewed
Dec 6, 2023
| sessionData.isomerUserId, | ||
| STAGING_BRANCH | ||
| ) | ||
| expect(pushSpy).toHaveBeenCalledWith(sessionData, expect.any(Boolean)) |
There was a problem hiding this comment.
we should check if push was done to both staging & lite branch right?
There was a problem hiding this comment.
applies to all the test cases :/
thanks for the catch, added 33bff68
| }) | ||
|
|
||
| // Assert | ||
| expect(deleteSpy).toHaveBeenCalledWith( |
There was a problem hiding this comment.
should assert if delete was called twice one for each branch right?
kishore03109
force-pushed
the
12-04-test_gitCommitService_add_test_cases
branch
2 times, most recently
from
46c7528 to
3e85ab2
Compare
harishv7
approved these changes
Dec 6, 2023
Merge activity
|
kishore03109
force-pushed
the
12-04-feat_gitFileSystem_safer_api
branch
from
27d9fd6 to
7d9bced
Compare
kishore03109
changed the base branch from
12-04-feat_gitFileSystem_safer_api
to
develop
kishore03109
force-pushed
the
12-04-test_gitCommitService_add_test_cases
branch
from
d2ab13c to
b995436
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add test cases for
GitFileCommitService.