Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make NodeAddresses Configuration optional #44

Merged
merged 5 commits into from
Dec 19, 2024

Conversation

defo89
Copy link
Contributor

@defo89 defo89 commented Dec 17, 2024

Proposed Changes

  • add network options to the config (easier to extend) that has an ability to enable/disable node address configuration

Tested in capi cluster to use node internal-ip other than discovery one:

apiVersion: v1
kind: ConfigMap
metadata:
  name: cloud-provider-config
  namespace: kube-system
data:
  cloudprovider.conf: |
    clusterName: capi-cluster
    networking:
      configureNodeAddresses: false

Fixes #18

@defo89 defo89 added the enhancement New feature or request label Dec 17, 2024
@defo89 defo89 requested a review from a team as a code owner December 17, 2024 10:46
pkg/cloudprovider/metal/config.go Outdated Show resolved Hide resolved
@defo89 defo89 requested a review from afritzler December 17, 2024 12:48
@github-actions github-actions bot added size/L and removed size/M labels Dec 17, 2024
Copy link
Member

@afritzler afritzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor thing.

pkg/cloudprovider/metal/instances_v2_test.go Outdated Show resolved Hide resolved
@defo89 defo89 requested a review from afritzler December 19, 2024 09:18
@defo89 defo89 merged commit c2f8079 into main Dec 19, 2024
8 checks passed
@defo89 defo89 deleted the enh-configureNodeAddresses-optional branch December 19, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size/L
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Node InternalIP may not be the same as Server networkInterfaces
2 participants