Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CCM Networking config #101

Merged
merged 6 commits into from
Dec 20, 2024
Merged

Add CCM Networking config #101

merged 6 commits into from
Dec 20, 2024

Conversation

defo89
Copy link
Contributor

@defo89 defo89 commented Dec 18, 2024

Proposed Changes

  • extend ccm chart with networking value to disable configuring node addresses. Default: true
  • adds ability to configure the value via Shoot spec.

Depends on ironcore-dev/cloud-provider-metal#44

@defo89 defo89 added the enhancement New feature or request label Dec 18, 2024
@defo89 defo89 requested a review from a team as a code owner December 18, 2024 16:02
@github-actions github-actions bot added size/L api-change controllers documentation Improvements or additions to documentation labels Dec 18, 2024
@defo89 defo89 requested a review from Nuckal777 December 19, 2024 16:14
pkg/apis/metal/types_controlplane.go Outdated Show resolved Hide resolved
pkg/apis/metal/v1alpha1/types_controlplane.go Outdated Show resolved Hide resolved
pkg/controller/controlplane/valuesprovider.go Outdated Show resolved Hide resolved
@defo89 defo89 requested a review from afritzler December 20, 2024 13:16
@defo89 defo89 merged commit 78454ab into main Dec 20, 2024
7 checks passed
@defo89 defo89 deleted the ccm-networking-config branch December 20, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-change controllers documentation Improvements or additions to documentation enhancement New feature or request size/L
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants