Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brazil suppliers #427

Merged
merged 8 commits into from
Nov 21, 2024
Merged

Brazil suppliers #427

merged 8 commits into from
Nov 21, 2024

Conversation

cavalle
Copy link
Contributor

@cavalle cavalle commented Nov 18, 2024

Describe your changes

Checklist before requesting a review

  • I have performed a self-review of my code.
  • I have added thorough tests with at least 90% code coverage.
  • I've modified or created example GOBL documents the show my changes in use, if appropriate.
  • When adding or modifying a tax regime or addon, I've added links to the source of the changes either structured or in the comments.
  • I've run go generate . to ensure that Schemas and Regime data are up to date.
  • All linter warnings have been reviewed and fixed.
  • I've been obsessive with pointer nil checks to avoid panics.
  • The CHANGELOG.md has been updated with an overview of my changes.
  • Requested a review from @samlown.

@cavalle cavalle marked this pull request as ready for review November 18, 2024 08:21
@cavalle cavalle requested a review from samlown November 18, 2024 08:21
@cavalle cavalle mentioned this pull request Nov 18, 2024
9 tasks
Copy link
Collaborator

@samlown samlown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! And thanks for fixing the examples links too :-)

addons/br/nfse/invoices.go Outdated Show resolved Hide resolved
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 94.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 81.45%. Comparing base (2ab8dff) to head (20f27e6).
Report is 33 commits behind head on main.

Files with missing lines Patch % Lines
addons/br/nfse/invoices.go 94.82% 2 Missing and 1 partial ⚠️
regimes/br/party.go 90.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #427      +/-   ##
==========================================
+ Coverage   81.34%   81.45%   +0.10%     
==========================================
  Files         231      232       +1     
  Lines       11369    11468      +99     
==========================================
+ Hits         9248     9341      +93     
- Misses       1760     1764       +4     
- Partials      361      363       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@cavalle cavalle merged commit 42442af into main Nov 21, 2024
7 checks passed
@cavalle cavalle deleted the br-issuer branch November 21, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants