Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brazil suppliers #426

Closed
wants to merge 4 commits into from
Closed

Brazil suppliers #426

wants to merge 4 commits into from

Conversation

cavalle
Copy link
Contributor

@cavalle cavalle commented Nov 18, 2024

Describe your changes

Checklist before requesting a review

  • I have performed a self-review of my code.
  • I have added thorough tests with at least 90% code coverage.
  • I've modified or created example GOBL documents the show my changes in use, if appropriate.
  • When adding or modifying a tax regime or addon, I've added links to the source of the changes either structured or in the comments.
  • I've run go generate . to ensure that Schemas and Regime data are up to date.
  • All linter warnings have been reviewed and fixed.
  • I've been obsessive with pointer nil checks to avoid panics.
  • The CHANGELOG.md has been updated with an overview of my changes.
  • Requested a review from @samlown.

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 94.11765% with 3 lines in your changes missing coverage. Please review.

Project coverage is 81.40%. Comparing base (2ab8dff) to head (4683cdc).

Files with missing lines Patch % Lines
addons/br/nfse/invoices.go 94.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #426      +/-   ##
==========================================
+ Coverage   81.34%   81.40%   +0.05%     
==========================================
  Files         231      231              
  Lines       11369    11420      +51     
==========================================
+ Hits         9248     9296      +48     
- Misses       1760     1762       +2     
- Partials      361      362       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cavalle cavalle force-pushed the br-issuer branch 2 times, most recently from 30e08be to b1b38c0 Compare November 18, 2024 08:01
@cavalle
Copy link
Contributor Author

cavalle commented Nov 18, 2024

Superseded by #427

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant