Fuel account balance complement to MX regime #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cavalle
commented
Sep 29, 2023
cavalle
commented
- Adds fuel account balance complement to MX regime used to generate the CFDI "EstadoDeCuentaCombustible" complement.
- Supersedes and applies the feedback discussed in Add basic structs for MX fuel complement #192.
- The GOBL complements maps one by one to every node and field of the CFDI complement.
- Implements validations according to the constrains of the the EstadoDeCuentaCombustible spec.
- Normalises all the amounts to the precisions (2, 3 or 6 decimals) specified in the EstadoDeCuentaCombustible spec.
- Calculates the grand subtotal and grand subtotal
- There are no line-level calculations as those must be calculated earlier when each fuel purchase was made by the purchase supplier.
This was referenced Sep 29, 2023
samlown
reviewed
Oct 4, 2023
regimes/mx/fuel_account_balance.go
Outdated
| FuelAccountTaxCodeIEPS = cbc.Code("IEPS") | ||
| ) | ||
|
|
||
| var validTaxCodes = []interface{}{ |
There was a problem hiding this comment.
This might need a prefix to avoid collisions:
Suggested change
| var validTaxCodes = []interface{}{ | |
| var fuelValidTaxCodes = []interface{}{ |
There was a problem hiding this comment.
I'll rename to FuelAccountTaxCodeVAT for consistency with the other constants and structs
There was a problem hiding this comment.
Addressed in ab524c9
|
Merging after addressing the latest feedback (additional comments always welcome!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.