Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to EstadoDeCuentaCombustible complement #15

Merged
merged 2 commits into from
Oct 5, 2023
Merged

Conversation

cavalle
Copy link
Contributor

@cavalle cavalle commented Sep 29, 2023

  • Converts from mx.FuelAccountBalance complement to CFDI's ecc2:EstadoDeCuentaCombustible
  • Mapping is very direct as the GOBL struct was designed for this purpose and the GOBL library already validates and massages the data.
  • Depends on Fuel account balance complement to MX regime gobl#210 => Make sure to update the mod.go file once the changes are released

@cavalle cavalle requested a review from samlown September 29, 2023 14:34
@cavalle cavalle force-pushed the fuel-complement branch 3 times, most recently from c3349a6 to 0ef4e31 Compare October 4, 2023 13:49
@cavalle cavalle marked this pull request as ready for review October 5, 2023 06:34
@cavalle
Copy link
Contributor Author

cavalle commented Oct 5, 2023

Merging to release the changes. Any further feedback still welcome!

@cavalle cavalle merged commit 092f5e6 into main Oct 5, 2023
2 checks passed
@cavalle cavalle deleted the fuel-complement branch November 24, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant