Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing bug on cmd #33

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Fixing bug on cmd #33

merged 1 commit into from
Jun 19, 2024

Conversation

Menendez6
Copy link
Contributor

While doing the gobl.tin cmd functionality, I was taking this as reference and I came up with 1 bug and I also updated the README:

  • If you use the command convert without arguments, the cmd crashes. To fix this I added a condition that when the number of arguments is not 1 or 2 an error displays.
  • In the README. documentation for cms used the the file ./test/data/invoice.json which no longer exists. I changed it for ./test/data/invoice-b2b-bare.json to match the response from below. I also changed the command for installing gobl.cfdi because the one before wasn't working: I proposed go install ./cmd/gobl.cfdi, which worked for me.

@Menendez6 Menendez6 requested review from cavalle and samlown June 19, 2024 11:31
Copy link
Contributor

@cavalle cavalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch and fix. Thanks!

@Menendez6 Menendez6 merged commit cd6036c into main Jun 19, 2024
2 checks passed
@Menendez6 Menendez6 deleted the cmd-bug-fix branch June 19, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants