Addenda Mabe generation #18
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cavalle
commented
Nov 21, 2023
| // MabeMoneda carries the data about the invoice's currency | ||
| type MabeMoneda struct { | ||
| TipoMoneda string `xml:"tipoMoneda,attr"` | ||
| TipoCambio string `xml:"tipoCambio,attr,omitempty"` // Not implemented yet |
There was a problem hiding this comment.
I left this one out of scope for the moment, as we need to add support for multiple currencies to the CFDI itself first and I didn't want to keep delaying things any further. Happy to implement it right after if we think it's worth the time of doing it now.
cavalle
commented
Nov 21, 2023
| type MabeMoneda struct { | ||
| TipoMoneda string `xml:"tipoMoneda,attr"` | ||
| TipoCambio string `xml:"tipoCambio,attr,omitempty"` // Not implemented yet | ||
| ImporteConLetra string `xml:"importeConLetra,attr,omitempty"` // Not implemented yet |
There was a problem hiding this comment.
I left this one out of scope because it's an optional field that I don't think adds any value.
cavalle
commented
Nov 21, 2023
Comment on lines
+84
to
+85
| PrecioConIva string `xml:"precioConIva,attr,omitempty"` // Not implemented yet | ||
| ImporteConIva string `xml:"importeConIva,attr,omitempty"` // Not implemented yet |
There was a problem hiding this comment.
I left these two fields out of scope because they're optional and I don't think they add any value
|
Superseded by #19 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go.modandgo.sumwhen the new GOBL version is released)