build(deps): get react-native code and CI working on current toolchains #933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the command `yarn build:all` to work with JDK17 JDK21 will also work, but it will fail on android until android-gradle-plugin 8.2.1 is released with an upstream google fix
without this tests would not build on a current toolchain
mikehardy
force-pushed
the
@mikehardy/dependency-updates
branch
from
9554c31 to
da0647e
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #933 +/- ##
=======================================
Coverage 77.41% 77.41%
=======================================
Files 32 32
Lines 1691 1691
Branches 546 567 +21
=======================================
Hits 1309 1309
+ Misses 381 333 -48
- Partials 1 49 +48 |
mikehardy
force-pushed
the
@mikehardy/dependency-updates
branch
2 times, most recently
from
a4f50b7 to
1015089
Compare
more modern toolchains - only avoiding macos-13+xcode-15 because the iOS performance is so terrible there that means we still rely on using the named iOS simulator "iPhone 14", which does not exist by default on fresh Xcode 15 installs, but you may create the Simulator definition easily, and it's still more modern than previous iPhone 12
mikehardy
force-pushed
the
@mikehardy/dependency-updates
branch
from
1015089 to
289d9e3
Compare
without the Cavy patch auto-linking fails as it requires the podspec at module root in modern react-native, and it has apparently been failing long enough that a bit of android-specific testing crept out of the android-specific testing area this also prepares the cavy native reporter for AGP8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The react-native bits were not even working on current (JDK17, Xcode 15, Node v18) versions of main development components, this gets things moving
Primarily it's adopting react-native 0.69.x in the tests_react_native app as that's what I'm using to verify changes
No attempt to bring non-vital things up to date yet, including the example app - just want basic ability to verify critical changes prior to making them