fix(android): android gradle plugin 8 compatibility #907
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #907 +/- ##
=======================================
Coverage 77.41% 77.41%
=======================================
Files 32 32
Lines 1691 1691
Branches 567 567
=======================================
Hits 1309 1309
Misses 333 333
Partials 49 49 |
|
Spoiler alert: CI not working. That's alright, I'm the CI whisperer. Will be working shortly |
|
Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 15 days until this gets closed automatically |
|
Hey Mike, with the official release of 0.73, is there anything holding this PR back? |
|
Yeah - I've got the go ahead to work in this repo now but when I went to check things and make sure I didn't break something by merging this I realized that I couldn't even build+test the repo on current toolchains 😬 Working through that with #933 then I'll get this out as a sort of "emergency priority" and then start reviving staled out issues+PRs and getting a regular release cadence going |
mikehardy
force-pushed
the
@mikehardy/agp-8-compat
branch
from
03da1a7 to
b18f5b7
Compare
adds shas, some transitives bumped
mikehardy
force-pushed
the
@mikehardy/agp-8-compat
branch
from
ab4c988 to
b5d4143
Compare
…ting check - requires that CI for formatting runs on mac so brew + clang / swift formatters are available easily
mikehardy
force-pushed
the
@mikehardy/agp-8-compat
branch
from
b5d4143 to
8742412
Compare
- use modern melos and configure it correctly - requires root-level pubspec - requires gitignore of pubspecs overrides - ...but pubspecs overrides allow internal cross-linking so pub check passes - required command-line level filter of test exec run to ignore example
mikehardy
force-pushed
the
@mikehardy/agp-8-compat
branch
from
8742412 to
7f5f9e2
Compare
|
I snuck in a bunch of unrelated Flutter CI changes since I needed to re-run CI a bunch anyway. Got all checks to go ✅ 🥳 |
|
This was just released as v7.8.1 - should be good to go @fobos531 - first time I've published this repo in a long long time, please let me know how it goes as you test integrate it, thanks! |
|
Thank you so much, appreciated! |
This was required locally when testing the module with android gradle plugin 8 which is included in upcoming react-native 0.73 release
Will also serve as an opening round of "is CI still working" in this repo