-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: improved Typedoc generation with async file handling and better error management #1112
Conversation
…tter error management
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
interesting! thanks - our docs are in flux right now and have been unpublished for quite some time so I don't have a great way to review this via actually looking at the result but the code changes seem reasonable.
I'm working on getting the docs publishing again and I'll give this a final review then once we can make sure things are still generating fine (they should be - but verifying is vital...)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1112 +/- ##
=======================================
Coverage 77.08% 77.08%
=======================================
Files 32 32
Lines 1727 1727
Branches 579 556 -23
=======================================
Hits 1331 1331
- Misses 343 395 +52
+ Partials 53 1 -52 |
thanks for you time @mikehardy |
Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 15 days until this gets closed automatically |
Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 15 days until this gets closed automatically |
I'm changing all of the docs generation now and hope to do typedocs without javascript, rather just with a config file in the future - this won't remain relevant, sorry |
Refactored the Typedoc generation script to enhance error handling, improve asynchronous file operations, and optimize JSON parsing for output.