-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): various dependency updates #1026
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probably related to alarm manager permissions required in newer APIs, needs triage
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1026 +/- ##
=======================================
Coverage 77.41% 77.41%
=======================================
Files 32 32
Lines 1691 1691
Branches 546 546
=======================================
Hits 1309 1309
Misses 381 381
Partials 1 1 |
these workflows haven't been updated since the feature came out, for our use case the built-in concurrency is superior to the external action
this should get rid of the CI warning messages about node16 support going away soon
should get rid of all the warnings associated with the set-output functionality going away in Github CI
mikehardy
force-pushed
the
@mikehardy/dependency-updates
branch
2 times, most recently
from
April 9, 2024 04:53
79de970
to
ebc23b9
Compare
…r tests ubuntu+nested-virt is now the preferred way to run android emulator tests, as it has no concurrency limits (unlike the macos runners) and the macos-14 runner (apple silicon, and macos runner future state) has no nested virt so cannot run the android emulators switching to the reactive-circus emulator reduces CI code and has been sucessful elsewhere
this allows us access to the most up to date Xcode / macOS combos, but they don't contain macOS 14 note: needs build testing to make sure we make a library that's compatible with apple silicon and intel silicon for macOS targets
mikehardy
force-pushed
the
@mikehardy/dependency-updates
branch
3 times, most recently
from
April 9, 2024 17:04
1d7ea77
to
db36980
Compare
the bash uploader was deprecated long ago and most likely no longer works, the action is the documented current way to upload coverage
the artifact uploader compresses things already, so this compression is unnecessary and actually makes viewing the logs (which you now have to decompress twice) more troublesome
entropy took over and the example was using a react-native version old enough that it no longer worked with current macOS toolchains bumped to latest react-native on 0.71-stable and disabled flipper so it works now
the build is failing once (and very slowly) then building second time (but also slowly), have the individual runs timeout in 30mins (observably possible to build when successful within that) and increase overall workflow timeout so hopefully we get a build that succeeds
mikehardy
force-pushed
the
@mikehardy/dependency-updates
branch
from
April 9, 2024 18:19
db36980
to
eb7eab5
Compare
This took long enough I'm going to defer the upgrades of test + example app so I can unblock community PR review and docs site publish |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals:
This should unblock the ability to verify community PRs that have been stagnant a while