Skip to content

Commit

Permalink
test(ci): remove log compression pre-artifact upload
Browse files Browse the repository at this point in the history
the artifact uploader compresses things already, so this compression
is unnecessary and actually makes viewing the logs (which you now have
to decompress twice) more troublesome
  • Loading branch information
mikehardy committed Apr 9, 2024
1 parent 67285f4 commit 79de970
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 12 deletions.
7 changes: 1 addition & 6 deletions .github/workflows/tests_e2e_android.yml
Original file line number Diff line number Diff line change
Expand Up @@ -180,17 +180,12 @@ jobs:
with:
verbose: true

- name: Compress Emulator Log
if: always()
run: gzip -9 adb-log.txt
shell: bash

- name: Upload Emulator Log
uses: actions/upload-artifact@v4
if: always()
with:
name: adb_logs
path: adb-log.txt.gz
path: adb-log.txt

- name: Upload Packager Log
uses: actions/upload-artifact@v4
Expand Down
7 changes: 1 addition & 6 deletions .github/workflows/tests_e2e_ios.yml
Original file line number Diff line number Diff line change
Expand Up @@ -209,18 +209,13 @@ jobs:
name: simulator_video
path: simulator.mp4

- name: Compress Simulator Log
continue-on-error: true
if: always()
run: gzip -9 simulator.log

- name: Upload Simulator Log
uses: actions/upload-artifact@v4
continue-on-error: true
if: always()
with:
name: simulator_logs
path: simulator.log.gz
path: simulator.log

- name: Upload Packager Log
uses: actions/upload-artifact@v4
Expand Down

0 comments on commit 79de970

Please sign in to comment.