Enhance PSNR Check for Luma (Y) Channel in VPP Sharpen Filter #697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @feiwan1 , can you review this for me? |
Hangjie22Coder
force-pushed
the
vpp-psnr-luma-check
branch
3 times, most recently
from
f7fd5b0 to
f4c1618
Compare
The current implementation of the PSNR check for the Luma (Y) channel raises exceptions for actual values exceeding reference values. This behavior is not reflective of typical processing scenarios where higher actual values are expected. Updated the `compare` function to only raise exceptions if the actual Luma (Y) value is lower than the reference value. Signed-off-by: Wang Hangjie <[email protected]>
Hangjie22Coder
force-pushed
the
vpp-psnr-luma-check
branch
from
f4c1618 to
4c900f9
Compare
uartie
reviewed
Nov 22, 2024
Comment on lines
+135
to
+138
| # Only assert if actual Luma (Y) is lower than reference, using specified range condition | ||
| if actual[-3] < ref[-3]: | ||
| # Ensure the difference is within the acceptable range [0, 0.25) | ||
| assert 0 <= ref[-3] - actual[-3] < 0.25, f"Luma (Y) is lower than reference value: {actual[-3]} < {ref[-3]}" |
There was a problem hiding this comment.
If luma is 100 in non-passthrough sharpen level, then it's a bug and this will cause that bug to escape.
There was a problem hiding this comment.
This change will not capture the issue reported in intel/media-driver#1881
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of the PSNR check for the Luma (Y) channel raises exceptions for actual values exceeding reference values. This behavior is not reflective of typical processing scenarios where higher actual values are expected.
Updated the
comparefunction to only raise exceptions if the actual Luma (Y) value is lower than the reference value.