Enhance PSNR Check for Luma (Y) Channel in VPP Sharpen Filter

The current implementation of the PSNR check for the Luma (Y) channel raises exceptions for actual values exceeding reference values. This behavior is not reflective of typical processing scenarios where higher actual values are expected. Updated the `compare` function to only raise exceptions if the actual Luma (Y) value is lower than the reference value. Signed-off-by: Wang Hangjie <[email protected]>
intel · Oct 25, 2024 · f4c1618 · f4c1618
1 parent 9b17a37
commit f4c1618
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/lib/mixin/vpp.py b/lib/mixin/vpp.py
@@ -132,7 +132,10 @@ def compare(k, ref, actual):
         assert actual[-2] == 100, "Cb(U) should not be affected by SHARPEN filter"
         assert actual[-1] == 100, "Cr(V) should not be affected by SHARPEN filter"
         assert ref is not None, "Invalid reference value"
-        assert abs(ref[-3] - actual[-3]) < 0.25, "Luma (Y) out of baseline range"
+        # Only check if the actual Luma (Y) value is lower than the reference.
+        # If the actual value is lower than the reference by more than 0.25, raise an exception.
+        if actual[-3] < ref[-3]:
+          assert ref[-3] - actual[-3] < 0.25, f"Luma (Y) is lower than reference value: {actual[-3]} < {ref[-3]}"
 
       metrics2.check(
         metric = dict(type = "psnr"), compare = compare,