Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds min package version #57

Merged
merged 9 commits into from
Oct 19, 2023
Merged

Adds min package version #57

merged 9 commits into from
Oct 19, 2023

Conversation

averissimo
Copy link
Contributor

@averissimo averissimo commented Sep 1, 2023

WIP :: parent issue: insightsengineering/nestdevs-tasks#7

🔴 Checklist for PR Reviewer

Scheduled 🕰️

  • Tag yourself next to this repo on Specify minimal version dependencies + add action nestdevs-tasks#7
  • Package versions are the same or higher than main
  • Package list is the same
    • Only exception is rmarkdown (may have been removed on Suggests)
  • All packages in Imports, Depends & Suggests are in new section Config/Needs/verdepcheck
  • Added entry to NEWS.md
  • Last scheduled.yaml action was run succesfully (all 4 strategies)
    • important: it's not the last commit, it's the one that runs 4 Scheduled 🕰️ / Dependency actions
  • scheduled.yaml SHOULD NOT have any push on any branches

🔴 What's needed before merging?

This PR depends on some upstream changes that need to be finalized/merged before being ready to review.

Change in code

  • verdepcheck.yml action (see comments)
    • Remove on: push section
    • Change branch to main

PRS

Changes description

  • Adds minimum version for packages DESCRIPTION
  • Adds Config/Need/verdepcheck section in DESCRIPTION
  • Updates verdepcheck action

@averissimo averissimo marked this pull request as ready for review September 28, 2023 15:10
@github-actions
Copy link
Contributor

github-actions bot commented Sep 28, 2023

badge

Code Coverage Summary

Filename             Stmts    Miss  Cover    Missing
-----------------  -------  ------  -------  ---------
R/tabulate_rbmi.R       82       0  100.00%
TOTAL                   82       0  100.00%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 29e190a

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

github-actions bot commented Sep 28, 2023

Unit Tests Summary

7 tests   7 ✔️  0s ⏱️
3 suites  0 💤
1 files    0

Results for commit 29e190a.

♻️ This comment has been updated with latest results.

@averissimo averissimo requested a review from a team October 18, 2023 14:19
#' @export
#' @return A dataframe
#'
tidy.pool <- function(x) { # nolint
tidy.pool <- function(x, ...) { # nolint
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

R CMD check error due to mismatch signature with generic tidy() function.

@kartikeyakirar kartikeyakirar self-assigned this Oct 19, 2023
@kartikeyakirar
Copy link

Added entry to NEWS.md

No news entry is present

@averissimo
Copy link
Contributor Author

Thanks @kartikeyakirar , should be good now

Copy link

@kartikeyakirar kartikeyakirar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@averissimo averissimo merged commit bb2b771 into main Oct 19, 2023
24 checks passed
@averissimo averissimo deleted the verdepcheck_action branch October 19, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants