Skip to content

Commit

Permalink
Adds min package version (#57)
Browse files Browse the repository at this point in the history
WIP :: parent issue:
insightsengineering/nestdevs-tasks#7

### 🔴 Checklist for PR Reviewer

[![Scheduled
🕰️](https://github.com/insightsengineering/tern.rbmi/actions/workflows/scheduled.yaml/badge.svg?branch=verdepcheck_action)](https://github.com/insightsengineering/tern.rbmi/actions/workflows/scheduled.yaml?query=branch%3Averdepcheck_action)

- [x] Tag yourself next to this repo on
insightsengineering/nestdevs-tasks#7
- [x] Package versions are the same or higher than `main`
- [x] Package list is the same
  - Only exception is `rmarkdown` (may have been removed on `Suggests`)
- [x] All packages in `Imports`, `Depends` & `Suggests` are in new
section `Config/Needs/verdepcheck`
- [x] Added entry to `NEWS.md`
- [x] Last `scheduled.yaml` action was run succesfully _(all 4
strategies)_
- important: it's not the last commit, it's the one that runs 4
`Scheduled 🕰️ / Dependency` actions
- [x] `scheduled.yaml` SHOULD NOT have any push on any branches

### 🔴 What's needed before merging?

This PR depends on some upstream changes that need to be
finalized/merged before being ready to review.

#### Change in code

* `verdepcheck.yml` action (see comments)
  - [x] Remove `on: push` section 
  - [x] Change branch to main

#### PRS

- [x] verdepcheck
  * insightsengineering/verdepcheck#24
  * insightsengineering/verdepcheck#26
- [x] verdepcheck-action
  * insightsengineering/r-verdepcheck-action#16

### Changes description

* Adds minimum version for packages `DESCRIPTION`
* Adds `Config/Need/verdepcheck` section in `DESCRIPTION`
* Updates verdepcheck action
  • Loading branch information
averissimo authored Oct 19, 2023
1 parent a398a6e commit bb2b771
Show file tree
Hide file tree
Showing 5 changed files with 33 additions and 13 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/scheduled.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
strategy:
fail-fast: false
matrix:
test-strategy: ["min", "release", "max"]
test-strategy: ["min_cohort", "min_isolated", "release", "max"]
uses: insightsengineering/r.pkg.template/.github/workflows/verdepcheck.yaml@main
name: Dependency Test - ${{ matrix.test-strategy }} 🔢
secrets:
Expand Down
34 changes: 24 additions & 10 deletions DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -14,26 +14,40 @@ URL: https://github.com/insightsengineering/tern.rbmi,
BugReports: https://github.com/insightsengineering/tern.rbmi/issues
Depends:
R (>= 3.6),
rbmi,
rbmi (>= 1.2.5),
tern (>= 0.7.10)
Imports:
broom,
checkmate,
broom (>= 0.5.4),
checkmate (>= 2.1.0),
formatters (>= 0.3.1),
lifecycle,
magrittr,
lifecycle (>= 0.2.0),
magrittr (>= 1.5),
rtables (>= 0.5.1)
Suggests:
dplyr,
knitr,
dplyr (>= 1.0.3),
knitr (>= 1.42),
Matrix,
rmarkdown,
testthat (>= 2.0),
tidyr
rmarkdown (>= 2.19),
testthat (>= 3.0.4),
tidyr (>= 0.8.3)
VignetteBuilder:
knitr
Remotes:
insightsengineering/tern@*release
Config/Needs/verdepcheck:
insightsengineering/rbmi,
insightsengineering/tern,
tidymodels/broom,
mllg/checkmate,
insightsengineering/formatters,
r-lib/lifecycle,
tidyverse/magrittr,
insightsengineering/rtables,
tidyverse/dplyr,
yihui/knitr,
rstudio/rmarkdown,
r-lib/testthat,
tidyverse/tidyr
Config/Needs/website: insightsengineering/nesttemplate
Encoding: UTF-8
Language: en-US
Expand Down
3 changes: 3 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# `tern.rbmi` 0.1.2.9008

* Specified minimal version of package dependencies.
* Corrected tidy.pool function signature

# `tern.rbmi` 0.1.2

* Add more tests and examples, coverage is at 100%!
Expand Down
3 changes: 2 additions & 1 deletion R/tabulate_rbmi.R
Original file line number Diff line number Diff line change
Expand Up @@ -64,10 +64,11 @@ h_tidy_pool <- function(x) {
#' @method tidy pool
#' @param x (`pool`) is a list of pooled object from `rbmi` analysis results. This list includes
#' analysis results, confidence level, hypothesis testing type.
#' @param ... Additional arguments. Not used. Needed to match generic signature only.
#' @export
#' @return A dataframe
#'
tidy.pool <- function(x) { # nolint
tidy.pool <- function(x, ...) { # nolint

ls_raw <- x$pars

Expand Down
4 changes: 3 additions & 1 deletion man/tidy.pool.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit bb2b771

Please sign in to comment.