642 unused functions #659
642 unused functions #659
Conversation
There was a problem hiding this comment.
The removal of substitute_q and extract_input looks good.
I'm not sure about exporting create_sparklines until https://github.com/insightsengineering/coredev-tasks/issues/510 is closed
| #' This might be retrieved like \code{teal.transform::data_extract_spec(...)[[1]]$dataname}. | ||
| #' @param filter logical if the connected \code{extract_data_spec} is used with \code{filter} option. | ||
| #' @keywords internal | ||
| extract_input <- function(varname, dataname, filter = FALSE) { |
There was a problem hiding this comment.
This function is a pure evil - it is clearly breaking encapsulation and introducing implementation details defined elsewhere in teal.transform. I disliked this from the very beginning. Happy to see it gone.
There is a clone of it in tmc but apparently it's used so not easy to remove...
There was a problem hiding this comment.
Yes, I saw that. Since we're not conducting works there, I decided to put it off for later.
There was a problem hiding this comment.
Would you mind raising an issue to get rid of the evil over there? Maybe we can improve it or replace it altogether.
There was a problem hiding this comment.
I will probably wait for bigger discussion about the future of teal.transform. Maybe we can overcome this in this way. Let's see.
Closes #642.
Removed
substitute_qandextract_input.Added
@keywords internaltois_num_var_short.